From 12905e116bfcd2706b7060615b5b4cac27f45b49 Mon Sep 17 00:00:00 2001 From: Adrian-Devries Date: Thu, 24 Apr 2025 12:54:06 +0200 Subject: [PATCH] 20-FixResourceManagementIssues --- .../cmd/CommandlineApplicationTest.java | 21 ++++++++++++------- .../cmd/ExtractHtmlActionTest.java | 5 ++++- 2 files changed, 17 insertions(+), 9 deletions(-) diff --git a/src/test/java/de/kosit/validationtool/cmd/CommandlineApplicationTest.java b/src/test/java/de/kosit/validationtool/cmd/CommandlineApplicationTest.java index 247c0ff..bdda19b 100644 --- a/src/test/java/de/kosit/validationtool/cmd/CommandlineApplicationTest.java +++ b/src/test/java/de/kosit/validationtool/cmd/CommandlineApplicationTest.java @@ -30,6 +30,7 @@ import java.nio.file.Files; import java.nio.file.Path; import java.nio.file.Paths; import java.util.List; +import java.util.stream.Stream; import static de.kosit.validationtool.impl.Helper.ASSERTIONS; import static org.assertj.core.api.Assertions.assertThat; @@ -57,13 +58,15 @@ public class CommandlineApplicationTest { @After public void cleanup() throws IOException { - Files.list(Paths.get("")).filter(p -> p.getFileName().toString().endsWith("-report.xml")).forEach(path -> { - try { - Files.delete(path); - } catch (final IOException e) { - log.error("Error deleting file", e); - } - }); + try ( Stream stream = Files.list(Paths.get("")) ) { + stream.filter(p -> p.getFileName().toString().endsWith("-report.xml")).forEach(path -> { + try { + Files.delete(path); + } catch (final IOException e) { + log.error("Error deleting file", e); + } + }); + } CommandLine.deactivate(); } @@ -186,7 +189,9 @@ public class CommandlineApplicationTest { Paths.get(Simple.SIMPLE_VALID).toString() }; CommandLineApplication.mainProgram(args); assertThat(CommandLine.getErrorOutput()).contains(RESULT_OUTPUT); - assertThat(Files.list(this.output).filter(f -> f.toString().endsWith(".html")).count()).isPositive(); + try ( Stream stream = Files.list(this.output) ) { + assertThat(stream.filter(f -> f.toString().endsWith(".html")).count()).isPositive(); + } } @Test diff --git a/src/test/java/de/kosit/validationtool/cmd/ExtractHtmlActionTest.java b/src/test/java/de/kosit/validationtool/cmd/ExtractHtmlActionTest.java index 2d04e55..a4966fb 100644 --- a/src/test/java/de/kosit/validationtool/cmd/ExtractHtmlActionTest.java +++ b/src/test/java/de/kosit/validationtool/cmd/ExtractHtmlActionTest.java @@ -30,6 +30,7 @@ import java.io.IOException; import java.nio.file.Files; import java.nio.file.Path; import java.util.stream.Collectors; +import java.util.stream.Stream; import static org.assertj.core.api.Assertions.assertThat; @@ -64,6 +65,8 @@ public class ExtractHtmlActionTest { assertThat(this.action.isSkipped(b)).isFalse(); this.action.check(b); assertThat(b.isStopped()).isFalse(); - assertThat(Files.list(this.tmpDirectory).collect(Collectors.toList())).hasSize(1); + try ( Stream stream = Files.list(this.tmpDirectory) ) { + assertThat(stream.collect(Collectors.toList())).hasSize(1); + } } }