diff --git a/src/main/java/de/kosit/validationtool/api/InputFactory.java b/src/main/java/de/kosit/validationtool/api/InputFactory.java index 5339cf1..bcf0e87 100644 --- a/src/main/java/de/kosit/validationtool/api/InputFactory.java +++ b/src/main/java/de/kosit/validationtool/api/InputFactory.java @@ -191,6 +191,7 @@ public class InputFactory { * @param name the digest algorithm * @return an {@link Input} */ + @SuppressWarnings("unused") public static Input read(final Source source, final String name) { checkNotEmpty(name); return read(source, name, PSEUDO_NAME_ALGORITHM, name.getBytes()); diff --git a/src/main/java/de/kosit/validationtool/api/XmlError.java b/src/main/java/de/kosit/validationtool/api/XmlError.java index 7b67ceb..47dfb81 100644 --- a/src/main/java/de/kosit/validationtool/api/XmlError.java +++ b/src/main/java/de/kosit/validationtool/api/XmlError.java @@ -36,6 +36,7 @@ public interface XmlError { * @return der Schweregrad * @see Severity */ + @SuppressWarnings("unused") Severity getSeverity(); /** @@ -53,7 +54,9 @@ public interface XmlError { Integer getColumnNumber(); enum Severity { - SEVERITY_WARNING, SEVERITY_ERROR, SEVERITY_FATAL_ERROR + @SuppressWarnings("unused") + SEVERITY_WARNING, SEVERITY_ERROR, @SuppressWarnings("unused") + SEVERITY_FATAL_ERROR } } diff --git a/src/main/java/de/kosit/validationtool/cmd/CheckAssertionAction.java b/src/main/java/de/kosit/validationtool/cmd/CheckAssertionAction.java index 1970a6e..91b6dcb 100644 --- a/src/main/java/de/kosit/validationtool/cmd/CheckAssertionAction.java +++ b/src/main/java/de/kosit/validationtool/cmd/CheckAssertionAction.java @@ -97,7 +97,7 @@ class CheckAssertionAction implements CheckAction { } - private XPathSelector createSelector(AssertionType assertion) throws SaxonApiException { + private XPathSelector createSelector(AssertionType assertion) { try { final XPathCompiler compiler = getProcessor().newXPathCompiler(); assertions.getNamespace().forEach(ns -> compiler.declareNamespace(ns.getPrefix(), ns.getValue())); diff --git a/src/main/java/de/kosit/validationtool/cmd/CommandLineApplication.java b/src/main/java/de/kosit/validationtool/cmd/CommandLineApplication.java index 588b88e..98062bf 100644 --- a/src/main/java/de/kosit/validationtool/cmd/CommandLineApplication.java +++ b/src/main/java/de/kosit/validationtool/cmd/CommandLineApplication.java @@ -94,16 +94,22 @@ public class CommandLineApplication { return resultStatus; } - private static int logExecutionException(final Exception ex, final CommandLine cli, final ParseResult parseResult) { + @SuppressWarnings("SameReturnValue") + private static int logExecutionException(final Exception ex, @SuppressWarnings("unused") final CommandLine cli, + @SuppressWarnings("unused") final ParseResult parseResult) { final String message = isNotEmpty(ex.getMessage()) ? ex.getMessage() : "Es ist eine Fehler aufgetreten"; Printer.writeErr(ex, message); return 1; } + @SuppressWarnings("unused") enum Level { - - INFO, WARN, DEBUG, TRACE, ERROR, OFF - + @SuppressWarnings("unused") + INFO, @SuppressWarnings("unused") + WARN, @SuppressWarnings("unused") + DEBUG, @SuppressWarnings("unused") + TRACE, @SuppressWarnings("unused") + ERROR, @SuppressWarnings("unused") + OFF } - } diff --git a/src/main/java/de/kosit/validationtool/cmd/CommandLineOptions.java b/src/main/java/de/kosit/validationtool/cmd/CommandLineOptions.java index 484948c..8bad1fa 100644 --- a/src/main/java/de/kosit/validationtool/cmd/CommandLineOptions.java +++ b/src/main/java/de/kosit/validationtool/cmd/CommandLineOptions.java @@ -35,8 +35,7 @@ import java.util.concurrent.Callable; * * @author Andreas Penski */ -@Command(description = "Structural and semantic validation of xml files", name = "KoSIT Validator", mixinStandardHelpOptions = false, - separator = " ") +@Command(description = "Structural and semantic validation of xml files", name = "KoSIT Validator", separator = " ") @Getter public class CommandLineOptions implements Callable { @@ -166,7 +165,7 @@ public class CommandLineOptions implements Callable { private List scenarios; @Override - public ReturnValue call() throws Exception { + public ReturnValue call() { configureLogging(this); return Validator.mainProgram(this); } diff --git a/src/main/java/de/kosit/validationtool/cmd/TypeConverter.java b/src/main/java/de/kosit/validationtool/cmd/TypeConverter.java index 96e67d0..3210d58 100644 --- a/src/main/java/de/kosit/validationtool/cmd/TypeConverter.java +++ b/src/main/java/de/kosit/validationtool/cmd/TypeConverter.java @@ -76,7 +76,7 @@ class TypeConverter { public static class RepositoryConverter implements ITypeConverter { @Override - public RepositoryDefinition convert(final String value) throws Exception { + public RepositoryDefinition convert(final String value) { return TypeConverter.convert(RepositoryDefinition.class, value); } } @@ -89,7 +89,7 @@ class TypeConverter { public static class ScenarioConverter implements ITypeConverter { @Override - public ScenarioDefinition convert(final String value) throws Exception { + public ScenarioDefinition convert(final String value) { return TypeConverter.convert(ScenarioDefinition.class, value); } } diff --git a/src/main/java/de/kosit/validationtool/cmd/Validator.java b/src/main/java/de/kosit/validationtool/cmd/Validator.java index 1b391f7..eca7f09 100644 --- a/src/main/java/de/kosit/validationtool/cmd/Validator.java +++ b/src/main/java/de/kosit/validationtool/cmd/Validator.java @@ -320,6 +320,7 @@ public class Validator { } + @SuppressWarnings("SameParameterValue") private static void assertFileExistance(final Path f, final String type) { if (!Files.isRegularFile(f)) { throw new IllegalArgumentException( diff --git a/src/main/java/de/kosit/validationtool/cmd/report/Format.java b/src/main/java/de/kosit/validationtool/cmd/report/Format.java index 6d5141f..58ad531 100644 --- a/src/main/java/de/kosit/validationtool/cmd/report/Format.java +++ b/src/main/java/de/kosit/validationtool/cmd/report/Format.java @@ -68,6 +68,7 @@ public class Format { * * @return this {@link Format} */ + @SuppressWarnings("unused") public Format color(final Code textColor) { this.textColor = textColor; return this; @@ -80,6 +81,7 @@ public class Format { * * @return this {@link Format} */ + @SuppressWarnings("unused") public Format background(final Code color) { this.background = color; return this; diff --git a/src/main/java/de/kosit/validationtool/cmd/report/Grid.java b/src/main/java/de/kosit/validationtool/cmd/report/Grid.java index c0a9ed7..d43c257 100644 --- a/src/main/java/de/kosit/validationtool/cmd/report/Grid.java +++ b/src/main/java/de/kosit/validationtool/cmd/report/Grid.java @@ -61,6 +61,7 @@ public class Grid { * * @param name the name of the column */ + @SuppressWarnings("unused") public ColumnDefinition(final String name) { this(name, -1, -1, 1); } @@ -147,6 +148,7 @@ public class Grid { this.text.add(txt); } + @SuppressWarnings("unused") public Cell(final Object object, final Code... codes) { this(new Text(object, codes)); } @@ -192,6 +194,7 @@ public class Grid { } + @SuppressWarnings("unused") public Cell add(final Object object, final Code... codes) { this.text.add(new Text(object, codes)); return this; @@ -237,6 +240,7 @@ public class Grid { * @param def definitions * @return this grid */ + @SuppressWarnings("unused") public Grid addColumn(final ColumnDefinition def) { this.definitions.add(def); return this; @@ -263,6 +267,7 @@ public class Grid { return this; } + @SuppressWarnings("unused") public Grid addCell(final Text... text) { return addCell(new Cell(Arrays.asList(text))); } @@ -274,6 +279,7 @@ public class Grid { return addCell(new Cell(t)); } + @SuppressWarnings("UnusedReturnValue") public Grid addCell(final Object cell) { return addCell(cell, DEFAULT_FORMAT.getTextColor()); } diff --git a/src/main/java/de/kosit/validationtool/cmd/report/Justify.java b/src/main/java/de/kosit/validationtool/cmd/report/Justify.java index bd7180a..2a44df1 100644 --- a/src/main/java/de/kosit/validationtool/cmd/report/Justify.java +++ b/src/main/java/de/kosit/validationtool/cmd/report/Justify.java @@ -39,8 +39,10 @@ public enum Justify { return StringUtils.center(string, length); } }, + @SuppressWarnings("unused") RIGHT { + @SuppressWarnings("unused") @Override public String apply(final String string, final int length) { return StringUtils.leftPad(string, length); diff --git a/src/main/java/de/kosit/validationtool/cmd/report/Line.java b/src/main/java/de/kosit/validationtool/cmd/report/Line.java index 0416575..5e43c8d 100644 --- a/src/main/java/de/kosit/validationtool/cmd/report/Line.java +++ b/src/main/java/de/kosit/validationtool/cmd/report/Line.java @@ -71,6 +71,7 @@ public class Line { return add(new Text(text, codes)); } + @SuppressWarnings("UnusedReturnValue") public Line add(final Object text, final Format format) { return add(new Text(text, format)); } @@ -107,6 +108,7 @@ public class Line { return this.texts.stream().mapToInt(Text::getLength).sum(); } + @SuppressWarnings("unused") public static String render(final String text, final Code... codes) { return new Line().add(text, codes).render(); } diff --git a/src/main/java/de/kosit/validationtool/config/Builder.java b/src/main/java/de/kosit/validationtool/config/Builder.java index 948ef21..eb33bc4 100644 --- a/src/main/java/de/kosit/validationtool/config/Builder.java +++ b/src/main/java/de/kosit/validationtool/config/Builder.java @@ -32,5 +32,6 @@ interface Builder { * @param repository the {@link ContentRepository} * @return the result of building the object */ + @SuppressWarnings("unused") Result build(ContentRepository repository); } diff --git a/src/main/java/de/kosit/validationtool/config/ConfigurationBuilder.java b/src/main/java/de/kosit/validationtool/config/ConfigurationBuilder.java index 12b26b3..822694c 100644 --- a/src/main/java/de/kosit/validationtool/config/ConfigurationBuilder.java +++ b/src/main/java/de/kosit/validationtool/config/ConfigurationBuilder.java @@ -174,6 +174,7 @@ public class ConfigurationBuilder { * * @return a fallback configuration */ + @SuppressWarnings("unused") public static FallbackBuilder defaultFallback() { throw new NotImplementedException("Not yet defined"); } @@ -193,6 +194,7 @@ public class ConfigurationBuilder { * * @return a configuration builder for schema */ + @SuppressWarnings("unused") public static SchemaBuilder schema() { return new SchemaBuilder(); } @@ -204,6 +206,7 @@ public class ConfigurationBuilder { * @param schema the actual precompiled schema to use * @return a configuration builder for schema */ + @SuppressWarnings("unused") public static SchemaBuilder schema(final String name, final Schema schema) { return new SchemaBuilder().name(name).schema(schema); } @@ -243,6 +246,7 @@ public class ConfigurationBuilder { * * @return the scenario configuration builder */ + @SuppressWarnings("unused") public static ScenarioBuilder scenario() { return scenario(null); } @@ -350,6 +354,7 @@ public class ConfigurationBuilder { * @param strategy the strategy * @return this */ + @SuppressWarnings("unused") public ConfigurationBuilder resolvingStrategy(final ResolvingConfigurationStrategy strategy) { this.resolvingConfigurationStrategy = strategy; return this; @@ -372,6 +377,7 @@ public class ConfigurationBuilder { * @param repository the repository location * @return this */ + @SuppressWarnings("unused") public ConfigurationBuilder useRepository(final Path repository) { return useRepository(repository.toUri()); } diff --git a/src/main/java/de/kosit/validationtool/config/ConfigurationLoader.java b/src/main/java/de/kosit/validationtool/config/ConfigurationLoader.java index 798db4f..151299f 100644 --- a/src/main/java/de/kosit/validationtool/config/ConfigurationLoader.java +++ b/src/main/java/de/kosit/validationtool/config/ConfigurationLoader.java @@ -222,6 +222,7 @@ public class ConfigurationLoader { * @param value the parameter value object * @return this */ + @SuppressWarnings("unused") public ConfigurationLoader addParameter(final String name, final Object value) { this.parameters.put(name, value); return this; diff --git a/src/main/java/de/kosit/validationtool/config/FallbackBuilder.java b/src/main/java/de/kosit/validationtool/config/FallbackBuilder.java index 71151e7..f616dc6 100644 --- a/src/main/java/de/kosit/validationtool/config/FallbackBuilder.java +++ b/src/main/java/de/kosit/validationtool/config/FallbackBuilder.java @@ -84,6 +84,7 @@ public class FallbackBuilder implements Builder { * @param source the source * @return this */ + @SuppressWarnings("unused") public FallbackBuilder source(final URI source) { this.internal.source(source); return this; @@ -96,6 +97,7 @@ public class FallbackBuilder implements Builder { * @param source the source * @return this */ + @SuppressWarnings("unused") public FallbackBuilder source(final Path source) { this.internal.source(source); return this; diff --git a/src/main/java/de/kosit/validationtool/config/ReportBuilder.java b/src/main/java/de/kosit/validationtool/config/ReportBuilder.java index 8158037..6901173 100644 --- a/src/main/java/de/kosit/validationtool/config/ReportBuilder.java +++ b/src/main/java/de/kosit/validationtool/config/ReportBuilder.java @@ -112,6 +112,7 @@ public class ReportBuilder implements Builder List filterSchematronResult(final Class type) { return getSchematronResult() != null ? getSchematronResult().stream().flatMap(e -> e.getActivePatternAndFiredRuleAndFailedAssert().stream()) diff --git a/src/main/java/de/kosit/validationtool/impl/HtmlExtractor.java b/src/main/java/de/kosit/validationtool/impl/HtmlExtractor.java index 60b03a0..64a7234 100644 --- a/src/main/java/de/kosit/validationtool/impl/HtmlExtractor.java +++ b/src/main/java/de/kosit/validationtool/impl/HtmlExtractor.java @@ -71,6 +71,7 @@ public class HtmlExtractor { return this.executable.load(); } + @SuppressWarnings("SameParameterValue") private XPathExecutable createXPath(final String expression, final Map namespaces) { try { final XPathCompiler compiler = this.processor.newXPathCompiler(); diff --git a/src/main/java/de/kosit/validationtool/impl/ResolvingMode.java b/src/main/java/de/kosit/validationtool/impl/ResolvingMode.java index 194de34..3164954 100644 --- a/src/main/java/de/kosit/validationtool/impl/ResolvingMode.java +++ b/src/main/java/de/kosit/validationtool/impl/ResolvingMode.java @@ -38,10 +38,12 @@ public enum ResolvingMode { }, + @SuppressWarnings("unused") STRICT_LOCAL(new StrictLocalResolvingStrategy()), ALLOW_REMOTE(new RemoteResolvingStrategy()), + @SuppressWarnings("unused") CUSTOM(null); @Getter diff --git a/src/main/java/de/kosit/validationtool/impl/input/LazyReadInput.java b/src/main/java/de/kosit/validationtool/impl/input/LazyReadInput.java index f2c1760..e3afb50 100644 --- a/src/main/java/de/kosit/validationtool/impl/input/LazyReadInput.java +++ b/src/main/java/de/kosit/validationtool/impl/input/LazyReadInput.java @@ -40,6 +40,7 @@ interface LazyReadInput { * * @return true when computed */ + @SuppressWarnings("unused") boolean isHashcodeComputed(); /** diff --git a/src/main/java/de/kosit/validationtool/impl/input/SourceInput.java b/src/main/java/de/kosit/validationtool/impl/input/SourceInput.java index 2ea0c3d..0c6ffea 100644 --- a/src/main/java/de/kosit/validationtool/impl/input/SourceInput.java +++ b/src/main/java/de/kosit/validationtool/impl/input/SourceInput.java @@ -58,6 +58,7 @@ public final class SourceInput extends AbstractInput { private final String digestAlgorithm; + @SuppressWarnings("unused") public SourceInput(final StreamSource source, final String name, final String digestAlgorithm) { this(source, name, digestAlgorithm, null); } @@ -99,7 +100,7 @@ public final class SourceInput extends AbstractInput { return isStreamSource(); } - private boolean isConsumed() throws IOException { + private boolean isConsumed() { if (isStreamSource()) { final StreamSource ss = (StreamSource) this.source; diff --git a/src/main/java/de/kosit/validationtool/impl/model/Result.java b/src/main/java/de/kosit/validationtool/impl/model/Result.java index a120c9a..7ead20c 100644 --- a/src/main/java/de/kosit/validationtool/impl/model/Result.java +++ b/src/main/java/de/kosit/validationtool/impl/model/Result.java @@ -37,6 +37,7 @@ public class Result { private T object; + @SuppressWarnings("CanBeFinal") private Collection errors = new ArrayList<>(); /** diff --git a/src/main/java/de/kosit/validationtool/impl/tasks/CreateReportAction.java b/src/main/java/de/kosit/validationtool/impl/tasks/CreateReportAction.java index 2c274ce..9be4622 100644 --- a/src/main/java/de/kosit/validationtool/impl/tasks/CreateReportAction.java +++ b/src/main/java/de/kosit/validationtool/impl/tasks/CreateReportAction.java @@ -138,7 +138,7 @@ public class CreateReportAction implements CheckAction { } @Override - public boolean getFeature(final String name) throws SAXNotRecognizedException, SAXNotSupportedException { + public boolean getFeature(final String name) { if (SAX_FEATURES_NAMESPACES.equals(name)) { return true; } else if (SAX_FEATURES_NAMESPACE_PREFIXES.equals(name)) { @@ -149,7 +149,7 @@ public class CreateReportAction implements CheckAction { } @Override - public void setFeature(final String name, final boolean value) throws SAXNotRecognizedException, SAXNotSupportedException { + public void setFeature(final String name, final boolean value) throws SAXNotRecognizedException { // this inverts the logic from JaxbSource pseude parser if (name.equals(SAX_FEATURES_NAMESPACES) && !value) { throw new SAXNotRecognizedException(name); diff --git a/src/main/java/de/kosit/validationtool/impl/xml/BaseResolvingStrategy.java b/src/main/java/de/kosit/validationtool/impl/xml/BaseResolvingStrategy.java index 5b0146c..a850e1d 100644 --- a/src/main/java/de/kosit/validationtool/impl/xml/BaseResolvingStrategy.java +++ b/src/main/java/de/kosit/validationtool/impl/xml/BaseResolvingStrategy.java @@ -73,6 +73,7 @@ public abstract class BaseResolvingStrategy implements ResolvingConfigurationStr allowExternalSchema(schemaFactory, false, scheme); } + @SuppressWarnings("SameParameterValue") protected void allowExternalSchema(final Validator validator, final boolean lenient, final String... schemes) { final String schemeString = String.join(",", schemes); setProperty(() -> validator.setProperty(XMLConstants.ACCESS_EXTERNAL_SCHEMA, schemeString), lenient, format( @@ -93,6 +94,7 @@ public abstract class BaseResolvingStrategy implements ResolvingConfigurationStr disableExternalEntities(schemaFactory, false); } + @SuppressWarnings("SameParameterValue") protected void disableExternalEntities(final Validator validator, final boolean lenient) { log.debug("Try to disable extern DTD access"); setProperty(() -> validator.setProperty(XMLConstants.ACCESS_EXTERNAL_DTD, ""), lenient, @@ -100,6 +102,7 @@ public abstract class BaseResolvingStrategy implements ResolvingConfigurationStr } + @SuppressWarnings("SameParameterValue") protected void disableExternalEntities(final SchemaFactory schemaFactory, final boolean lenient) { log.debug("Try to disable extern DTD access"); setProperty(() -> schemaFactory.setProperty(XMLConstants.ACCESS_EXTERNAL_DTD, ""), lenient, diff --git a/src/main/java/de/kosit/validationtool/impl/xml/ProcessorProvider.java b/src/main/java/de/kosit/validationtool/impl/xml/ProcessorProvider.java index 1c99e92..7353cc3 100644 --- a/src/main/java/de/kosit/validationtool/impl/xml/ProcessorProvider.java +++ b/src/main/java/de/kosit/validationtool/impl/xml/ProcessorProvider.java @@ -26,11 +26,9 @@ import net.sf.saxon.lib.OutputURIResolver; import net.sf.saxon.lib.ResourceCollection; import net.sf.saxon.lib.UnparsedTextURIResolver; import net.sf.saxon.s9api.Processor; -import net.sf.saxon.trans.XPathException; import javax.xml.XMLConstants; import javax.xml.transform.Result; -import javax.xml.transform.TransformerException; import java.io.Reader; import java.net.URI; import java.net.URLEncoder; @@ -51,22 +49,22 @@ public class ProcessorProvider { } @Override - public Result resolve(final String href, final String base) throws TransformerException { + public Result resolve(final String href, final String base) { throw new IllegalStateException(MESSAGE); } @Override - public void close(final Result result) throws TransformerException { + public void close(final Result result) { throw new IllegalStateException(MESSAGE); } @Override - public Reader resolve(final URI absoluteURI, final String encoding, final Configuration config) throws XPathException { + public Reader resolve(final URI absoluteURI, final String encoding, final Configuration config) { throw new IllegalStateException(MESSAGE); } @Override - public ResourceCollection findCollection(final XPathContext context, final String collectionURI) throws XPathException { + public ResourceCollection findCollection(final XPathContext context, final String collectionURI) { throw new IllegalStateException(MESSAGE); } } diff --git a/src/test/java/de/kosit/validationtool/api/InputFactoryTest.java b/src/test/java/de/kosit/validationtool/api/InputFactoryTest.java index fa2fcc6..126f684 100644 --- a/src/test/java/de/kosit/validationtool/api/InputFactoryTest.java +++ b/src/test/java/de/kosit/validationtool/api/InputFactoryTest.java @@ -39,7 +39,6 @@ import java.io.File; import java.io.IOException; import java.io.InputStream; import java.io.InputStreamReader; -import java.net.URISyntaxException; import java.net.URL; import java.nio.file.Paths; @@ -102,13 +101,13 @@ public class InputFactoryTest { } @Test - public void testInputFile() throws URISyntaxException { + public void testInputFile() { final Input input = InputFactory.read(new File(Simple.SIMPLE_VALID)); assertThat(input).isNotNull(); } @Test - public void testInputPath() throws URISyntaxException { + public void testInputPath() { final Input input = InputFactory.read(Paths.get(Simple.SIMPLE_VALID)); assertThat(input).isNotNull(); } @@ -124,7 +123,7 @@ public class InputFactoryTest { } @Test - public void testEmptyInputName() throws IOException { + public void testEmptyInputName() { assertThrows(IllegalArgumentException.class, () -> { final Input input = InputFactory.read(SOME_VALUE.getBytes(), ""); drain(input); diff --git a/src/test/java/de/kosit/validationtool/cmd/CheckAssertionActionTest.java b/src/test/java/de/kosit/validationtool/cmd/CheckAssertionActionTest.java index b559d0b..86480d1 100644 --- a/src/test/java/de/kosit/validationtool/cmd/CheckAssertionActionTest.java +++ b/src/test/java/de/kosit/validationtool/cmd/CheckAssertionActionTest.java @@ -25,7 +25,6 @@ import de.kosit.validationtool.model.reportInput.CreateReportInput; import org.junit.Before; import org.junit.Test; -import java.io.IOException; import java.net.URISyntaxException; import java.net.URL; @@ -45,7 +44,7 @@ public class CheckAssertionActionTest { private static final URL SAMPLE_ASSERTIONS = CheckAssertionActionTest.class.getResource("/examples/assertions/tests-xrechnung.xml"); @Before - public void setup() throws IOException { + public void setup() { CommandLine.activate(); } diff --git a/src/test/java/de/kosit/validationtool/cmd/CommandLine.java b/src/test/java/de/kosit/validationtool/cmd/CommandLine.java index e1b5a5c..b90abd6 100644 --- a/src/test/java/de/kosit/validationtool/cmd/CommandLine.java +++ b/src/test/java/de/kosit/validationtool/cmd/CommandLine.java @@ -106,7 +106,7 @@ public class CommandLine { return new InputStream() { @Override - public int read() throws IOException { + public int read() { return 0; } }; @@ -124,6 +124,7 @@ public class CommandLine { return readLines(out.getOut().toByteArray()); } + @SuppressWarnings("unused") public static List getErrorLines() { return readLines(error.getOut().toByteArray()); } diff --git a/src/test/java/de/kosit/validationtool/config/ScenarioBuilderTest.java b/src/test/java/de/kosit/validationtool/config/ScenarioBuilderTest.java index 98f6fda..2b37000 100644 --- a/src/test/java/de/kosit/validationtool/config/ScenarioBuilderTest.java +++ b/src/test/java/de/kosit/validationtool/config/ScenarioBuilderTest.java @@ -24,7 +24,6 @@ import java.util.List; import java.util.Map; import org.apache.commons.text.RandomStringGenerator; -import org.junit.Rule; import org.junit.Test; import de.kosit.validationtool.impl.ContentRepository; diff --git a/src/test/java/de/kosit/validationtool/impl/ContentRepositoryTest.java b/src/test/java/de/kosit/validationtool/impl/ContentRepositoryTest.java index 2407e74..f6cab9c 100644 --- a/src/test/java/de/kosit/validationtool/impl/ContentRepositoryTest.java +++ b/src/test/java/de/kosit/validationtool/impl/ContentRepositoryTest.java @@ -57,7 +57,7 @@ public class ContentRepositoryTest { } @Test - public void testCreateSchemaNotExisting() throws Exception { + public void testCreateSchemaNotExisting() { assertThrows(IllegalStateException.class, () -> this.repository.createSchema(Simple.NOT_EXISTING.toURL())); } diff --git a/src/test/java/de/kosit/validationtool/impl/ConversionServiceTest.java b/src/test/java/de/kosit/validationtool/impl/ConversionServiceTest.java index 4662113..a139ea7 100644 --- a/src/test/java/de/kosit/validationtool/impl/ConversionServiceTest.java +++ b/src/test/java/de/kosit/validationtool/impl/ConversionServiceTest.java @@ -20,7 +20,6 @@ import static org.assertj.core.api.Assertions.assertThat; import static org.junit.Assert.assertThrows; import java.io.Serializable; -import java.net.URISyntaxException; import java.net.URL; import org.junit.Before; @@ -94,12 +93,12 @@ public class ConversionServiceTest { } @Test - public void testUnmarshalUnknownType() throws URISyntaxException { + public void testUnmarshalUnknownType() { assertThrows(ConversionService.ConversionException.class, () -> this.service.readXml(Simple.SCENARIOS, ConversionService.class)); } @Test - public void testUnmarshalWithoutType() throws URISyntaxException { + public void testUnmarshalWithoutType() { assertThrows(ConversionService.ConversionException.class, () -> this.service.readXml(Simple.SCENARIOS, null)); } diff --git a/src/test/java/de/kosit/validationtool/impl/Helper.java b/src/test/java/de/kosit/validationtool/impl/Helper.java index 6f4660d..b4ee388 100644 --- a/src/test/java/de/kosit/validationtool/impl/Helper.java +++ b/src/test/java/de/kosit/validationtool/impl/Helper.java @@ -87,6 +87,7 @@ public class Helper { return new ContentRepository(Helper.getTestProcessor(), strategy, Simple.REPOSITORY_URI); } + @SuppressWarnings("SameReturnValue") public static URI getSchemaLocation() { return SCHEMA; } diff --git a/src/test/java/de/kosit/validationtool/impl/RelativeUriResolverTest.java b/src/test/java/de/kosit/validationtool/impl/RelativeUriResolverTest.java index 6986966..c6ddbe4 100644 --- a/src/test/java/de/kosit/validationtool/impl/RelativeUriResolverTest.java +++ b/src/test/java/de/kosit/validationtool/impl/RelativeUriResolverTest.java @@ -57,12 +57,12 @@ public class RelativeUriResolverTest { } @Test - public void testNotExisting() throws TransformerException { + public void testNotExisting() { assertThrows(TransformerException.class, () -> this.resolver.resolve("ubl-0001", BASE.toASCIIString())); } @Test - public void testOutOfPath() throws TransformerException { + public void testOutOfPath() { assertThrows(TransformerException.class, () -> this.resolver.resolve("../results/report.xml", BASE.toASCIIString())); } diff --git a/src/test/java/de/kosit/validationtool/impl/ScenarioRepositoryTest.java b/src/test/java/de/kosit/validationtool/impl/ScenarioRepositoryTest.java index 1f99b75..efb51a0 100644 --- a/src/test/java/de/kosit/validationtool/impl/ScenarioRepositoryTest.java +++ b/src/test/java/de/kosit/validationtool/impl/ScenarioRepositoryTest.java @@ -121,10 +121,12 @@ public class ScenarioRepositoryTest { assertThat(fallback).isNotSameAs(second.getFallbackScenario()); } + @SuppressWarnings("SameParameterValue") private XdmNode load(final URI uri) throws IOException { return Helper.parseDocument(this.configInstance.getContentRepository().getProcessor(), read(uri.toURL())).getObject(); } + @SuppressWarnings("SameParameterValue") private XPathExecutable createXpath(final String expression) { return this.configInstance.getContentRepository().createXPath(expression, new HashMap<>()); } diff --git a/src/test/java/de/kosit/validationtool/impl/VersioningTest.java b/src/test/java/de/kosit/validationtool/impl/VersioningTest.java index 6cbe1a1..4f53b50 100644 --- a/src/test/java/de/kosit/validationtool/impl/VersioningTest.java +++ b/src/test/java/de/kosit/validationtool/impl/VersioningTest.java @@ -16,7 +16,6 @@ package de.kosit.validationtool.impl; -import de.kosit.validationtool.impl.Helper.Simple; import de.kosit.validationtool.model.scenarios.Scenarios; import org.junit.Before; import org.junit.Test; @@ -62,13 +61,13 @@ public class VersioningTest { } @Test - public void testNewFeature() throws URISyntaxException { + public void testNewFeature() { assertThrows(ConversionService.ConversionException.class, () -> this.service.readXml(NEW_FEATURE.toURI(), Scenarios.class, SchemaProvider.getScenarioSchema())); } @Test - public void testNewVersion() throws URISyntaxException { + public void testNewVersion() { assertThrows(ConversionService.ConversionException.class, () -> this.service.readXml(NEW_VERSION.toURI(), Scenarios.class, SchemaProvider.getScenarioSchema())); } diff --git a/src/test/java/de/kosit/validationtool/impl/input/StreamHelperTest.java b/src/test/java/de/kosit/validationtool/impl/input/StreamHelperTest.java index 9773bf5..59d7076 100644 --- a/src/test/java/de/kosit/validationtool/impl/input/StreamHelperTest.java +++ b/src/test/java/de/kosit/validationtool/impl/input/StreamHelperTest.java @@ -43,7 +43,7 @@ public class StreamHelperTest { } @Override - public int available() throws IOException { + public int available() { return 0; } } diff --git a/src/test/java/de/kosit/validationtool/impl/tasks/SchemaValidatorActionTest.java b/src/test/java/de/kosit/validationtool/impl/tasks/SchemaValidatorActionTest.java index af4b84b..ab42d58 100644 --- a/src/test/java/de/kosit/validationtool/impl/tasks/SchemaValidatorActionTest.java +++ b/src/test/java/de/kosit/validationtool/impl/tasks/SchemaValidatorActionTest.java @@ -41,7 +41,6 @@ import java.net.MalformedURLException; import static de.kosit.validationtool.impl.tasks.TestBagBuilder.createBag; import static org.assertj.core.api.Assertions.assertThat; -import static org.mockito.ArgumentMatchers.any; import static org.mockito.Mockito.*; /** diff --git a/src/test/java/de/kosit/validationtool/impl/xml/BaseResolverConfigurationTest.java b/src/test/java/de/kosit/validationtool/impl/xml/BaseResolverConfigurationTest.java index 2cb9dcf..76e2d86 100644 --- a/src/test/java/de/kosit/validationtool/impl/xml/BaseResolverConfigurationTest.java +++ b/src/test/java/de/kosit/validationtool/impl/xml/BaseResolverConfigurationTest.java @@ -25,7 +25,6 @@ import javax.xml.XMLConstants; import javax.xml.validation.SchemaFactory; import static org.junit.Assert.assertThrows; -import static org.mockito.ArgumentMatchers.any; import static org.mockito.Mockito.*; /** diff --git a/src/test/java/de/kosit/validationtool/impl/xml/SchemaProviderTest.java b/src/test/java/de/kosit/validationtool/impl/xml/SchemaProviderTest.java index fb2b61a..7a042a2 100644 --- a/src/test/java/de/kosit/validationtool/impl/xml/SchemaProviderTest.java +++ b/src/test/java/de/kosit/validationtool/impl/xml/SchemaProviderTest.java @@ -23,8 +23,10 @@ import javax.xml.validation.SchemaFactory; /** * @author Andreas Penski */ +@SuppressWarnings("unused") public class SchemaProviderTest { + @SuppressWarnings("unused") private final SchemaFactory schemaFactory = ResolvingMode.STRICT_RELATIVE.getStrategy().createSchemaFactory(); } diff --git a/src/test/java/de/kosit/validationtool/impl/xml/StrictLocalResolvingTest.java b/src/test/java/de/kosit/validationtool/impl/xml/StrictLocalResolvingTest.java index 21f9d3e..04a22d2 100644 --- a/src/test/java/de/kosit/validationtool/impl/xml/StrictLocalResolvingTest.java +++ b/src/test/java/de/kosit/validationtool/impl/xml/StrictLocalResolvingTest.java @@ -35,7 +35,7 @@ import static org.junit.Assert.assertThrows; public class StrictLocalResolvingTest { @Test - public void testRemoteSchemaResolving() throws Exception { + public void testRemoteSchemaResolving() { final ResolvingConfigurationStrategy s = new StrictLocalResolvingStrategy(); final SchemaFactory schemaFactory = s.createSchemaFactory(); Throwable e = assertThrows(SAXParseException.class, () -> schemaFactory.newSchema(Resolving.SCHEMA_WITH_REMOTE_REFERENCE.toURL())); diff --git a/src/test/java/de/kosit/validationtool/impl/xml/StrictRelativeResolvingTest.java b/src/test/java/de/kosit/validationtool/impl/xml/StrictRelativeResolvingTest.java index d595c0c..1dd131d 100644 --- a/src/test/java/de/kosit/validationtool/impl/xml/StrictRelativeResolvingTest.java +++ b/src/test/java/de/kosit/validationtool/impl/xml/StrictRelativeResolvingTest.java @@ -35,7 +35,7 @@ import static org.junit.Assert.assertThrows; public class StrictRelativeResolvingTest { @Test - public void testRemoteSchemaResolving() throws Exception { + public void testRemoteSchemaResolving() { final ResolvingConfigurationStrategy s = new StrictLocalResolvingStrategy(); final SchemaFactory schemaFactory = s.createSchemaFactory(); Throwable e = assertThrows(SAXParseException.class, () -> schemaFactory.newSchema(Resolving.SCHEMA_WITH_REMOTE_REFERENCE.toURL()));