From d168e205702d481dc08f7ebd08c8191e66aed2c6 Mon Sep 17 00:00:00 2001
From: Renzo Kottmann <renzo.kottmann@finanzen.bremen.de>
Date: Mon, 1 Jul 2019 16:51:52 +0200
Subject: [PATCH] Get rid of BOM encofing in app-info.properties and changed
 engine name to english

---
 pom.xml                                | 49 +++++++++++++-------------
 src/main/resources/app-info.properties |  6 ++--
 2 files changed, 28 insertions(+), 27 deletions(-)

diff --git a/pom.xml b/pom.xml
index 398a62e..43adfd0 100644
--- a/pom.xml
+++ b/pom.xml
@@ -2,12 +2,12 @@
 <!-- License below -->
 <project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://maven.apache.org/POM/4.0.0" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
     <modelVersion>4.0.0</modelVersion>
-    
+
     <name>KoSIT XML Prüftool Implementierung</name>
-    
+
     <groupId>de.kosit</groupId>
     <version>1.1.0-SNAPSHOT</version>
-    
+
     <artifactId>validationtool</artifactId>
     <description>KoSIT XML Prüftool zur Prüfung von XML Dateien gegenüber definierten Szenarien.</description>
     <developers>
@@ -19,7 +19,7 @@
             <organizationUrl>http://www.xoev.de</organizationUrl>
         </developer>
         <developer>
-            
+
             <id>renzo.kottmann</id>
             <name>Renzo Kottmann</name>
             <organization>KoSIT</organization>
@@ -58,7 +58,7 @@
             <url>file:${project.basedir}/libs</url>
         </repository>
     </repositories>
-    
+
     <dependencies>
         <dependency>
             <groupId>org.projectlombok</groupId>
@@ -89,7 +89,7 @@
             <version>${version.slf4j}</version>
             <optional>true</optional>
         </dependency>
-        
+
         <dependency>
             <groupId>org.apache.commons</groupId>
             <artifactId>commons-lang3</artifactId>
@@ -130,20 +130,21 @@
             <artifactId>packaged-test-scenarios</artifactId>
             <version>1.0.0</version>
         </dependency>
-        
+
     </dependencies>
-    
+
     <build>
         <resources>
             <resource>
                 <directory>src/main/model</directory>
             </resource>
             <resource>
+                <!-- for logging and app info properties -->
                 <directory>src/main/resources</directory>
                 <filtering>true</filtering>
             </resource>
         </resources>
-        
+
         <plugins>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
@@ -175,7 +176,7 @@
                     <encoding>UTF-8</encoding>
                 </configuration>
             </plugin>
-            
+
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-shade-plugin</artifactId>
@@ -233,7 +234,7 @@
                     </execution>
                 </executions>
             </plugin>
-            
+
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-assembly-plugin</artifactId>
@@ -257,8 +258,8 @@
                     </execution>
                 </executions>
             </plugin>
-            
-            
+
+
             <plugin>
                 <!-- Integrate the /src/main/generated folder -->
                 <groupId>org.codehaus.mojo</groupId>
@@ -275,7 +276,7 @@
                             <sources>
                                 <source>src/generated/java</source>
                             </sources>
-                            
+
                         </configuration>
                     </execution>
                 </executions>
@@ -310,7 +311,7 @@
                     </plugins>
                 </configuration>
             </plugin>
-            
+
             <!-- Integrate code coverage -->
             <plugin>
                 <groupId>org.jacoco</groupId>
@@ -350,7 +351,7 @@
                     <argLine>-Dfile.encoding=UTF-8 ${jacocoArgumentsJUnit}</argLine>
                 </configuration>
             </plugin>
-            
+
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-source-plugin</artifactId>
@@ -364,7 +365,7 @@
                     </execution>
                 </executions>
             </plugin>
-            
+
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-release-plugin</artifactId>
@@ -373,7 +374,7 @@
                     <tagNameFormat>v@{project.version}</tagNameFormat>
                 </configuration>
             </plugin>
-            
+
             <plugin>
                 <groupId>org.codehaus.mojo</groupId>
                 <artifactId>exec-maven-plugin</artifactId>
@@ -401,9 +402,9 @@
                         <argument>-r</argument>
                         <argument>${project.build.testOutputDirectory}/examples/repository</argument>
                         <argument>-D</argument>
-                        
+
                     </arguments>
-                    
+
                 </configuration>
             </plugin>
             <plugin>
@@ -437,20 +438,20 @@
                             <goal>integration-test</goal>
                             <goal>verify</goal>
                         </goals>
-                        
+
                     </execution>
                 </executions>
             </plugin>
-            
+
         </plugins>
     </build>
-    
+
     <scm>
         <connection>https://github.com/itplr-kosit/validationtool.git</connection>
         <developerConnection>scm:git:https://github.com/itplr-kosit/validationtool.git</developerConnection>
         <tag>v1.0.0</tag>
     </scm>
-    
+
 </project> <!--
   ~ Licensed to the Koordinierungsstelle für IT-Standards (KoSIT) under
   ~ one or more contributor license agreements. See the NOTICE file
diff --git a/src/main/resources/app-info.properties b/src/main/resources/app-info.properties
index e19ce35..897e35f 100644
--- a/src/main/resources/app-info.properties
+++ b/src/main/resources/app-info.properties
@@ -1,9 +1,9 @@
-# do not edit this file
+# do not edit this file
 # this properties are overriden by build process
 project_version=${project.version}
 framework_version=1.0.0
-engine_name=KoSIT Prüftool
+engine_name=KoSIT Validator
 build_timestamp=${build.timestamp}
 build_number=${build.number}
 build_revision=${build.revision}
-build_branch=${build.branch}
\ No newline at end of file
+build_branch=${build.branch}